Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default for max-positional-args #9838

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

tmke8
Copy link
Contributor

@tmke8 tmke8 commented Feb 5, 2024

Summary

max-positional-args defaults to max-args if it's not specified and the default to max-args is 5, so saying that the default is 3 is definitely wrong. Ideally, we wouldn't specify a default at all for this config option, but I don't think that's possible?

Test Plan

Not sure.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) February 5, 2024 16:56
@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Feb 5, 2024
@charliermarsh charliermarsh merged commit e708c08 into astral-sh:main Feb 5, 2024
16 checks passed
@tmke8 tmke8 deleted the patch-2 branch February 5, 2024 16:58
Copy link
Contributor

github-actions bot commented Feb 5, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error)

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants