Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-circuit typing matches based on imports #9800

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

charliermarsh
Copy link
Member

No description provided.

@charliermarsh charliermarsh added the performance Potential performance improvement label Feb 2, 2024
@charliermarsh charliermarsh marked this pull request as ready for review February 2, 2024 20:32
Copy link
Contributor

github-actions bot commented Feb 2, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error)

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codspeed not impressed

@charliermarsh
Copy link
Member Author

Sigh. I see a minor speed-up on a few of them :D

@charliermarsh charliermarsh merged commit 5c99967 into main Feb 4, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/type branch February 4, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Potential performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants