Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use publicly available Apple Silicon runners #9726

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jan 31, 2024

Summary

This PR switches over to the macos-14 runners for our macOS wheel builds, which are GitHub's newly announced public M1 macOS runners (https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/).

Before:

After:

So it's like > 3x speedup for what is currently the bottleneck in our release pipeline.

@charliermarsh charliermarsh marked this pull request as ready for review January 31, 2024 01:24
@charliermarsh charliermarsh added the release Related to the release process label Jan 31, 2024
run: |
pip install dist/${{ env.PACKAGE_NAME }}-*.whl --force-reinstall
ruff --help
python -m ruff --help
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we can no longer run the x64_64 wheel (since this is an ARM runner, we're cross-compiling), but I think it's fine and worth it (we already run this test in the Universal branch below).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO if the M1 runner has Rostta2 enabled it should run fine? At least for ruff --help.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemme look back at what failed...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was the pip install dist/${{ env.PACKAGE_NAME }}-*.whl --force-reinstall, saying that the wheel isn't supported for the current platform.

Copy link
Contributor

@messense messense Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, the python interpreter it installed might not be universal2, if it is you can probably use arch -x86_64 python to switch to x86_64 mode.

Anyway it's definitly not a big issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate you chiming in, you're always so helpful.

Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@charliermarsh charliermarsh merged commit f0066e1 into main Jan 31, 2024
40 checks passed
@charliermarsh charliermarsh deleted the charlie/silicon branch January 31, 2024 15:36
charliermarsh added a commit that referenced this pull request Feb 5, 2024
charliermarsh added a commit that referenced this pull request Feb 5, 2024
## Summary

Sadly, the Apple Silicon runners use macOS 14 and produce binaries that
segfault when run on macOS 11 (at least), and possibly on macOS 12
and/or macOS 13.

macOS 11 is EOL, but it doesn't seem like a good tradeoff to speed up
our release builds at the expense of user support and compatibility.

This reverts commit f0066e1.

Closes #9823.
Czaki pushed a commit to Czaki/ruff that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants