Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUF023: Don't sort __match_args__, only __slots__ #9724

Merged
merged 1 commit into from
Jan 30, 2024
Merged

RUF023: Don't sort __match_args__, only __slots__ #9724

merged 1 commit into from
Jan 30, 2024

Conversation

AlexWaygood
Copy link
Member

Fixes #9723. I'm pretty embarrassed I forgot that order was important here :(

charliermarsh
charliermarsh approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good, burden also falls on the reviewers! Thanks for the quick response to the issue.

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -1 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

ibis-project/ibis (+0 -1 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview

- ibis/common/tests/test_graph.py:25:22: RUF023 [*] `MyNode.__match_args__` is not sorted

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF023 1 0 1 0 0

@AlexWaygood AlexWaygood merged commit 6bb1264 into astral-sh:main Jan 30, 2024
17 checks passed
@AlexWaygood AlexWaygood deleted the match-args-not-sorted branch January 30, 2024 22:44
@AlexWaygood AlexWaygood added the bug Something isn't working label Jan 30, 2024
@miccal miccal mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUF023: Sorting __match_args__ changes match semantics
2 participants
@AlexWaygood @charliermarsh