Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-pyi] Fix PYI047 false negatives on PEP-695 type aliases #9566

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

AlexWaygood
Copy link
Member

Summary

Fixes one of the issues listed in #8771. Fairly straightforward!

Test Plan

cargo test / cargo insta review

@AlexWaygood AlexWaygood added the rule Implementing or modifying a lint rule label Jan 17, 2024
@AlexWaygood AlexWaygood mentioned this pull request Jan 17, 2024
7 tasks
Copy link

codspeed-hq bot commented Jan 17, 2024

CodSpeed Performance Report

Merging #9566 will degrade performances by 4.35%

Comparing AlexWaygood:y047-695 (209182b) with main (368e279)

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main AlexWaygood:y047-695 Change
parser[numpy/ctypeslib.py] 12.2 ms 12.8 ms -4.35%

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking good!

@charliermarsh charliermarsh merged commit 848e473 into astral-sh:main Jan 18, 2024
16 of 17 checks passed
@AlexWaygood AlexWaygood deleted the y047-695 branch January 18, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants