Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-strings doesn't contain bytes literal for PLW0129 #8675

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 14, 2023

For the PLW0129 rule, the f-string case shouldn't match against bytes literal as f-strings cannot contain them. F-strings are made up of either string literals or formatted expressions.

@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila added the bug Something isn't working label Nov 14, 2023
@dhruvmanila dhruvmanila changed the title F-strings doesn't contain bytes literal F-strings doesn't contain bytes literal in PLW0129 Nov 14, 2023
@dhruvmanila dhruvmanila changed the title F-strings doesn't contain bytes literal in PLW0129 F-strings doesn't contain bytes literal for PLW0129 Nov 14, 2023
@dhruvmanila dhruvmanila merged commit 4099b96 into main Nov 14, 2023
17 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/PLW0129 branch November 14, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant