[pylint] Implement import-outside-toplevel (C0415)

[dankleeman]

Summary

Per #970 :
Implement pylint rule C0415: import-outside-toplevel

https://pylint.readthedocs.io/en/latest/user_guide/messages/convention/import-outside-toplevel.html

Test Plan

With cargo test following the contribution instructions.

[github-actions]

PR Check Results

Ecosystem

ℹ️ ecosystem check detected linter changes. (+1 -0 violations, +0 -0 fixes in 41 projects)

rotki/rotki (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero

+ tools/pyinstaller_hooks/pre_find_module_path/hook-distutils.py:40:5: PLC0415 Import outside toplevel (opcode)

Changes by rule (1 rules affected)

code	total	+ violation	- violation	+ fix	- fix
PLC0415	1	1	0	0	0

[charliermarsh]

Ugh, so sorry -- thank you for getting involved but unfortunately there's already an open PR for this rule, which I've just been slow to merge (#5180). Is there any way I can help you pick out another rule to work on?

[dankleeman]

Ugh, so sorry -- thank you for getting involved but unfortunately there's already an open PR for this rule, which I've just been slow to merge (#5180). Is there any way I can help you pick out another rule to work on?

No worries! I'd love to work on other rules. I'd happily take a shot at any rule you'd suggest.

I think my only concern picking another one on my own is the discussion on #970 that mentions not wanting to implement pylint rules that are covered by mypy: #970 (comment)

[charliermarsh]

Awesome! Here are a few that look reasonable to me:

• bad-staticmethod-argument
• unnecessary-dunder-call
• too-many-locals

Separately: @zanieb was actually planning to go through and move all the Mypy-overlapping rules to a separate section to avoid this issue in the future.