Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(parser): use faster string parser methods #8227

Merged
merged 6 commits into from
Oct 28, 2023
Merged

perf(parser): use faster string parser methods #8227

merged 6 commits into from
Oct 28, 2023

Commits on Oct 25, 2023

  1. perf(parser): use faster string parsing 

    This makes use of memchr for parsing strings. It sadly does introduce
one use of `unsafe` to create a string that is valid to pass into
`u32::from_str_radix` because I was unable to find another method that
does not require far more code than required with `unsafe`.
    @sno2
    sno2 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    893cf42 View commit details
    Browse the repository at this point in the history

  2. fix escape followed by unicode character

    @sno2
    sno2 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    28eba86 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. fix panic when unicode name starts with... 

    multi-byte UTF-8 characters
    @sno2
    sno2 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    05acb28 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. push to string after error handling

    @sno2
    sno2 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    af7ef4e View commit details
    Browse the repository at this point in the history

  2. use find() instead of memchr

    @sno2
    sno2 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    c577879 View commit details
    Browse the repository at this point in the history

  3. Update crates/ruff_python_parser/src/string.rs 

    Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
    @sno2 @dhruvmanila
    sno2 and dhruvmanila committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    28b823f View commit details
    Browse the repository at this point in the history