Parenthesize match..case
if
guards
#13513
Merged
+155
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the black
remove_redundant_guard_parens
andparens_for_long_if_clauses_in_case_block
preview styles.Black deviation
Like assignments, ruff prefers splitting the right side (if guard) over splitting the left (case).
Black
Ruff
Test Plan
There are a few existing tests that cover this already nicely. I added a few new tests to ensure that comments are handled correctly.