[flake8-async] Update ASYNC109 to match upstream
#12236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Thank you. This looks good to me.
The only change is that I think we should gate this behind preview-mode because it increases the scope of a non-preview rule.
Would you mind to extend the PR summary with a short explanation of what "match upstream" means (support anyio and asyncio). The person who has to write the changelog and people navigating to the PR from the changelog might find that helpful.
|
Ok I restricted the rule to trio only unless preview is enabled |
|
I expanded the PR summary to make things a little clearer. |
charliermarsh
approved these changes
Jul 9, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the name of
ASYNC109to match upstream.Also update to the functionality to match upstream by supporting additional context managers from
asyncioandanyio. This doesn't change any of the detection functionality, but recommends additional context managers fromasyncioandanyiodepending on context.Part of #12039.
Test Plan
Added fixture for asyncio recommendation