[Ruff 0.5] Stabilise manual-dict-comprehension
(PERF403
)
#12045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This rule's been in preview for a very long time (over 9 months, if I'm not mistaken). There are no open issues about it, the docs accurately describe what it does, and the implementation seems sound.
It's an opinionated rule that advocates a micro-optimisation -- but this is true for all the perflint rules, and is flagged in the docs. I don't think you'd enable the
PERF
category at all if you weren't interested in this kind of rule.