Remove string allocation in relative import formatting (#7743)

astral-sh · Oct 1, 2023 · d8a6279 · d8a6279
1 parent 2838f7a
commit d8a6279
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/crates/ruff_python_formatter/src/statement/stmt_import_from.rs b/crates/ruff_python_formatter/src/statement/stmt_import_from.rs
@@ -20,16 +20,17 @@ impl FormatNodeRule<StmtImportFrom> for FormatStmtImportFrom {
             range: _,
         } = item;
 
-        let level_str = level
-            .map(|level| ".".repeat(level as usize))
-            .unwrap_or(String::default());
-
         write!(
             f,
             [
                 token("from"),
                 space(),
-                text(&level_str, None),
+                format_with(|f| {
+                    for _ in 0..level.unwrap_or(0) {
+                        token(".").fmt(f)?;
+                    }
+                    Ok(())
+                }),
                 module.as_ref().map(AsFormat::format),
                 space(),
                 token("import"),