forked from RocketChat/Rocket.Chat
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Rocket.Chat 0.73 #565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#12599) * Exposing SideNav variable from rocketchat-ui * Convert rocketchat-custom-sounds to main module structure * Fix RocketChatFileCustomSoundsInstance export * Revert wrong settings in custom-sounds
…livechat rest api requests when CORS is enabled. (RocketChat#12561)
…Chat#12642) * Convert rocketchat-github-enterprise to main module structure * Removing forgot console.log
* Convert rocketchat-file to main module structure * Import RocketChatFile in packages that use it
…age package (RocketChat#12647) * Added imports for global variables in rocketchat-google-natural-language package * fix lint
* Added rooms.info endpoint * Added rooms.leave endpoint and tests * Add support to fields in room.info endpoint * fix broken tests, removed "lm" property from expected keys
* Fix favico error * Fix favico export, remove iife
…2564) This change adds a description of `[Shift|Ctrl] ESC` to the keyboard shortcuts sidebar. It also adds some more information on the description of the function.
* Exposing t function to the server side too * Convert rocketchat-grant to main module structure
…12661) * Convert rocketchat-iframe-login to main module structure * Revert some global variables removed
…at#12666) * Exposing getAvatarUrlFromUsername function * Convert rocketchat-importer-slack to main module structure
…12670) * Convert rocketchat-integrations to main module structure * import processWebhookMessage where it was missing
…ketChat#12651) * Spotlight: return joinCodeRequired for rooms * add missing trailing comma
* Added "npm install" to quick start for developers * Changed npm install to meteor npm install
Closes RocketChat/Rocket.Chat.Electron#740 Colleagues of mine found the issue why the CPU usage of rocket.chat is so high. It's because of `animateTransform` inside `./packages/rocketchat-ui-master/public/icons.svg`. I've removed it and replaced by a CSS animation.
…hat#13049) * Execute tests with versions 3.2, 3.4, 3.6 and 4.0 of MongoDB * Reduce duplicated configuration * Fix image inherintence * Fix test of mongo 4 without oplog
Release 0.73.1
* Cloud package inside of rocket.chat, enforcing a few items now * Implementing more of the requirements to get cloud up * Fix the linter error. Really should have the linter run on commit, not push. * Switch callback to webview and rename some of the variables * fix additional lint * clean up * remove console log * use check for register server on statistics * Implement calling the server-to-cloud and store the tokens * Add the workspace token to various services Rocket.Chat, the company, provides * Clean up the html spacing in the cloud.html * Remove the check on stats for sending the organization email * Cloud workspace and user connected * Update to include refresh token now that cloud does * Add a license api and try/catches * Add support for the token in the url of the admin/cloud page * Change redirectUrl var to redirectUri. dont save scope, and remove workspace scope * fix messy looking if * try increasing wait time on test * add missing import after merge with develop * Check users email * Don't save the org email from the wizard * Fix the review issues, adding i18n * Remove console.log Co-Authored-By: geekgonecrazy <geekgonecrazy@users.noreply.github.com>
Release 0.73.2
ghost
assigned mrsimpson
Jan 28, 2019
ghost
added
the
progress:working
label
Jan 28, 2019
mrsimpson
changed the title
Adhere to latest linter-restrictions - remove globals
Merge Rocket.Chat 0.73
Jan 28, 2019
ghost
assigned vickyokrm
Feb 26, 2019
|
Have you verified livechat? Sent with GitHawk |
Live chat tests are successful. |
Threading- no change, working as expected. |
All sets are thru! |
vickyokrm
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested. All units tests ran thru!. Good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a major release with a lot of merge conflicts.
Majorly, auto translation, threading and setting based permissions were giving conflicts.
=> Some manual testing is definitely required