Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds MapAssert.containsExactly assertion #64

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Adds MapAssert.containsExactly assertion #64

merged 2 commits into from
Mar 25, 2019

Conversation

mchmielarz
Copy link
Collaborator

#56 containsExactly part

@mchmielarz mchmielarz added this to the v0.2.0 milestone Mar 20, 2019
@mchmielarz mchmielarz self-assigned this Mar 20, 2019
Opalo
Opalo approved these changes Mar 24, 2019
View reviewed changes
Copy link

@Opalo Opalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things.

src/main/java/org/assertj/vavr/api/AbstractMapAssert.java Show resolved Hide resolved
src/main/java/org/assertj/vavr/internal/Maps.java Outdated Show resolved Hide resolved
src/main/java/org/assertj/vavr/internal/Maps.java Show resolved Hide resolved
src/test/java/org/assertj/vavr/api/MapAssert_containsExactly_Test.java Outdated Show resolved Hide resolved
src/test/java/org/assertj/vavr/api/MapAssert_containsExactly_Test.java Outdated Show resolved Hide resolved
src/test/java/org/assertj/vavr/api/MapAssert_containsExactly_Test.java Show resolved Hide resolved
Opalo
Opalo approved these changes Mar 24, 2019
View reviewed changes
Copy link

@Opalo Opalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things.

@mchmielarz mchmielarz merged commit c59347c into master Mar 25, 2019
@mchmielarz mchmielarz deleted the map-assert-contains-exactly branch March 25, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Opalo Opalo Opalo approved these changes

@pivovarit pivovarit Awaiting requested review from pivovarit

Assignees

@mchmielarz mchmielarz

Labels
enhancement
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mchmielarz @Opalo