Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to assertj-core 3.17.2 #101

Merged
merged 6 commits into from
Sep 20, 2020
Merged

upgrade to assertj-core 3.17.2 #101

merged 6 commits into from
Sep 20, 2020

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Sep 5, 2020 •
edited
Loading

AssertJ 3.17.2 is the latest version of assertj-core

@sullis sullis mentioned this pull request Sep 5, 2020
Closed
@sullis sullis mentioned this pull request Sep 5, 2020
Closed
@sullis sullis changed the title upgrade to assertj-core 3.17.1 upgrade to assertj-core 3.17.2 Sep 7, 2020
@sullis sullis mentioned this pull request Sep 7, 2020
Closed
pivovarit
pivovarit approved these changes Sep 7, 2020
View reviewed changes
Copy link
Collaborator

@pivovarit pivovarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like a lot of annoying work!

Waiting for @mchmielarz to have a look as well

@sullis
Copy link
Contributor Author

sullis commented Sep 11, 2020

ping @mchmielarz

mchmielarz
mchmielarz reviewed Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@mchmielarz mchmielarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no tests checking size greater/less/equal assertions. Could you add them?

src/main/java/org/assertj/vavr/api/AbstractMultimapAssert.java Show resolved Hide resolved
@sullis
add additional unit tests
c9fa6db 
MapAssert_hasSizeGreaterThan_Test
MapAssert_hasSizeLessThan_Test
MapAssert_isEqualTo_Test
MultimapAssert_hasSizeGreaterThan_Test
MultimapAssert_hasSizeLessThan_Test
MultiMapAssert_isEqualTo_Test
@sullis
add MapAssert_isNotEqualTo_Test.java
741fcef
@sullis
add MultiMapAssert_isNotEqualTo_Test
5f6d4c9
@sullis
Copy link
Contributor Author

sullis commented Sep 20, 2020 •
edited
Loading

I see no tests checking size greater/less/equal assertions. Could you add them?

I added additional tests:

  • MapAssert_hasSizeGreaterThan_Test
  • MapAssert_hasSizeLessThan_Test
  • MapAssert_isEqualTo_Test
  • MapAssert_isNotEqualTo_Test
  • MultimapAssert_hasSizeGreaterThan_Test
  • MultimapAssert_hasSizeLessThan_Test
  • MultiMapAssert_isEqualTo_Test
  • MultiMapAssert_isNotEqualTo_Test

@sullis
Copy link
Contributor Author

sullis commented Sep 20, 2020

@pivovarit @mchmielarz I have no further work planned. Can we merge this PR?

@mchmielarz
Copy link
Collaborator

Good work! 💯 Thank you!

@mchmielarz mchmielarz merged commit 391e2b9 into assertj:main Sep 20, 2020
@sullis sullis deleted the assertj-core-3.17.1 branch September 22, 2020 18:44
@pivovarit pivovarit added dependencies Pull requests that update a dependency file enhancement and removed dependencies Pull requests that update a dependency file labels Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchmielarz mchmielarz mchmielarz left review comments

@pivovarit pivovarit pivovarit approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sullis @mchmielarz @pivovarit