Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VavrAssumptions public methods return package-private types #141

Closed
kennymacleod opened this issue Feb 16, 2021 · 1 comment
Closed

VavrAssumptions public methods return package-private types #141

kennymacleod opened this issue Feb 16, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@kennymacleod
Copy link

The various assumeThat methods in the VavrAssumptions class return package-private types rather than the public types returned by VavrAssertions.

For example, whereas VavrAssertions#assertThat(Map) returns a public MapAssert type, VavrAssumptions#assumeThat(Map) returns a package-private AbstractMapAssert type.

As a result, none of the assumeThat methods are usable from code outside of that package, since they won't even compile.

@mchmielarz mchmielarz self-assigned this Feb 22, 2021
@mchmielarz
Copy link
Collaborator

Good point @kennymacleod! Will fix it!

@mchmielarz mchmielarz added the bug label Feb 22, 2021
@mchmielarz mchmielarz added this to the v0.4.1 milestone Feb 22, 2021
mchmielarz added a commit that referenced this issue Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants