This repository has been archived by the owner on Jan 1, 2024. It is now read-only.
Fix Vanity::Rails::Helpers#vanity_js for Rails 6; and fix Appraisal definitions #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually adds Rails 6 and 6.1 to Appraisals Fixes Vanity::Rails::Helpers#vanity_js for Rails 6, because of https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#default-template-handler-is-now-raw
|
@ariel-codes thanks for catching that 🎉 Do you feel equipped to tackle those errors, or do you need a hand? |
# Conflicts: # Gemfile.lock
|
Whew! 😓 Took a minute to get to green 🟢 Thank you @ariel-codes for catching the problem and fixing it! 🎉 |
bensheldon
changed the title
bensheldon
changed the title
|
This has been released 🎉 : https://github.com/assaf/vanity/releases/tag/v4.0.3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Rails 6 and 6.1 to Appraisals and fixes Vanity::Rails::Helpers#vanity_js for Rails 6, as in Rails 6+
render file:isn't rendered through ERB anymore. Resolves #390.Not particularly satisfied with my current solution, but it seemed the simplest one.