Skip to content
This repository has been archived by the owner on Jan 1, 2024. It is now read-only.

Update template rendering and update_attributes for Rails 6.1; adds Appraisals for Rails 6.0 and 6.1 #366

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

bensheldon
Copy link
Collaborator

@bensheldon bensheldon commented Dec 14, 2020

  • Rails 6.1 removes render file: '' support for templates. This has been replaced with prepend_view_path to include template root. There is a pre-existing TODO to convert to an Engine, which would clean this all right up.
  • Rails 6.1 removes ActiveRecord::Base#update_attributes; replaced with #update
  • Adds Appraisals for Rails 6.0 and 6.1

@frostmark
Copy link
Contributor

Hey @phillbaker. Maybe I will fix the specs and we will merge that?

@phillbaker
Copy link
Collaborator

👋 I'm not actively working on this open source project any more.

@assaf I'm not sure if you've given other folks contributor access to this repo, if not, let's maybe open an issue and ask for volunteers?

@frostmark
Copy link
Contributor

That would be nice!

@bensheldon
Copy link
Collaborator Author

I have repository access, but not to release on Rubygems. I can pick this up again if no one else is quicker to overcome the challenges.

@bensheldon
Copy link
Collaborator Author

@frostmark that would be fantastic if you can get this passing in local development.

I opened up #369 to try to get CI running again on the project.

@phillbaker
Copy link
Collaborator

phillbaker commented Jan 26, 2022 via email

@bensheldon bensheldon force-pushed the rails_6_1 branch 4 times, most recently from cbb29fe to dc076e8 Compare January 27, 2022 01:16
@bensheldon
Copy link
Collaborator Author

Oops, I shouldn't have rebased this branch because I realized people have the old commit pinned 🤦 I just undid that so the original commit is in the branch.

@bensheldon bensheldon changed the title Update template rendering and update_attributes for Rails 6.1 Update template rendering and update_attributes for Rails 6.1; adds Appraisals for Rails 6.0 and 6.1 Jan 27, 2022
@bensheldon
Copy link
Collaborator Author

Tests are green; I tried it on my own application. I guess it's ready 🚀

@bensheldon bensheldon merged commit e24f78c into master Jan 27, 2022
@bensheldon bensheldon deleted the rails_6_1 branch January 27, 2022 02:02
@bensheldon bensheldon restored the rails_6_1 branch January 27, 2022 02:02
@frostmark
Copy link
Contributor

That awesome!

@bensheldon
Copy link
Collaborator Author

I released this on rubygems in v3.0.1 too 🥳

@bensheldon bensheldon deleted the rails_6_1 branch January 29, 2022 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants