Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Duplicate bound attributes should flow through as unbound attributes. #418

Closed
NTaylorMullen opened this issue Jun 4, 2015 · 2 comments
Closed

Duplicate bound attributes should flow through as unbound attributes. #418

NTaylorMullen opened this issue Jun 4, 2015 · 2 comments
Assignees
@NTaylorMullen
Labels
3 - Done bug
Milestone
1.0.0-beta6

Comments

@NTaylorMullen
Copy link
Member

If you have a TagHelper with duplicate (same name) attributes only the first attribute gets added to TagHelperContext.AllAttributes. Ex:

<myTagHelper abc="..." ABC="..." />

Today the second one ABC is ignored completely. Instead it should flow through to the output as if it were unbound.
@NTaylorMullen NTaylorMullen mentioned this issue Jun 4, 2015
Merged
@dougbu
Copy link
Member

dougbu commented Jun 4, 2015

Same thing happens even when the attribute names have identical case e.g.

 <myTagHelper name="value1" name="value2" />

Only the first name / value pair (containing "value1") will be in AllAttributes.

@danroth27 danroth27 added this to the 4.0.0-beta6 milestone Jun 15, 2015
@NTaylorMullen NTaylorMullen changed the title Duplicate bound attributes only insert first attribute into .AllAttributes. Duplicate bound attributes should flow through as unbound attributes. Jun 23, 2015
NTaylorMullen added a commit that referenced this issue Jun 23, 2015
@NTaylorMullen
Change duplicate TagHelper bound attributes to flow to output.
8a9eaa2 
- Duplicate TagHelper bound attributes used to be ignored entirely; they now flow to the output as if they were unbound.
- Added code generation test to verify duplicate attributes. Added runtime and design time versions.
- Updated existing tests that happened to have duplicate bound attributes.

#418
This was referenced Jun 23, 2015
Merged
Closed
NTaylorMullen added a commit that referenced this issue Jun 25, 2015
@NTaylorMullen
Change duplicate TagHelper bound attributes to flow to output.
0bb9457 
- Duplicate TagHelper bound attributes used to be ignored entirely; they now flow to the output as if they were unbound.
- Added code generation test to verify duplicate attributes. Added runtime and design time versions.
- Updated existing tests that happened to have duplicate bound attributes.

#418
@NTaylorMullen
Copy link
Member Author

0bb9457

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta6
Development

No branches or pull requests
3 participants
@danroth27 @NTaylorMullen @dougbu