This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
To de-dupe, we must remove (again) #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- part of dotnet/extensions#93 - use `WebEncoders` from Common repo - leave some of `WebEncodersTests` to ensure resources are brought in correctly
|
|
(once the package is available)
|
|
|
When checking this, could you do this in two passes (first check in the Common change followed by the 2 repo changes)? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebEncodersclass dotnet/extensions#93WebEncodersfrom Common repoWebEncodersTeststo ensure resources are brought in correctly