Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Caching] remove implicit cast from CachedWord to Word (1.7%) #1607

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

adamsitnik
Copy link
Contributor

obraz

load before after
CPU Usage (%) 22 22
Cores usage (%) 605 615
Working Set (MB) 48 48
Build Time (ms) 3,733 3,973
Start Time (ms) 0 0
Published Size (KB) 76,401 76,401
First Request (ms) 67 66
Requests/sec 268,293 272,573
Requests 4,051,004 4,115,679
Mean latency (ms) 1.11 1.11
Max latency (ms) 41.51 42.72
Bad responses 0 0
Socket errors 0 0
Read throughput (MB/s) 844.32 857.79
Latency 50th (ms) 0.93 0.91
Latency 75th (ms) 1.03 1.01
Latency 90th (ms) 1.15 1.14
Latency 99th (ms) 8.74 9.01

@adamsitnik
Copy link
Contributor Author

@sebastienros ping

@sebastienros
Copy link
Member

I was giving @benaadams some time to comment too.

@benaadams
Copy link
Contributor

I was giving @benaadams some time to comment too.

PR to TE? Not long left for Round 20

image

@adamsitnik adamsitnik deleted the noImplicitCast branch December 15, 2020 11:15
@adamsitnik
Copy link
Contributor Author

PR to TE? Not long left for Round 20

It was just 1.7% and all my MemoryCache improvements will be part of 6.0, so I think that we can skip this round for this particular benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants