Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mocking trait methods whose return values have lifetime parameters #304

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

asomers
Copy link
Owner

@asomers asomers commented Jul 2, 2021

Must staticize return values for trait methods with generic arguments,
as long as the mock object itself is not generic.

This was a regression introduced by PR #274, and released in v0.10.0. It
only affects trait methods, not struct methods.

Fixes #298

Must staticize return values for trait methods with generic arguments,
as long as the mock object itself is not generic.

This was a regression introduced by PR #274, and released in v0.10.0. It
only affects trait methods, not struct methods.

Fixes #298
@asomers asomers merged commit 9949f1d into master Jul 2, 2021
@asomers asomers deleted the issue_298 branch July 2, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.10.0 breaks a mock that was working with 0.9.1
1 participant