Allow mocking methods with lifetime parameters of generic structs #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, generic structs implementing Future. The method must not be treated as a generic method, since it has a non-static argument. Issue #223
This can happen with automock when the impl block has where clauses that apply to some methods, but not others.
asomers
added a commit
that referenced
this pull request
Nov 3, 2020
It turns out that it wasn't necessary. PR #225 was sufficient to fix the issue. And #226 is awkward, because it can result in the expect_ methods having fewer generic parameters than the original methods. Worse, sometimes mockall will generate code that fails to compile, because the Where clauses reference generic parameters that aren't there.
Merged
asomers
added a commit
that referenced
this pull request
Nov 3, 2020
It turns out that it wasn't necessary. PR #225 was sufficient to fix the issue. And #226 is awkward, because it can result in the expect_ methods having fewer generic parameters than the original methods. Worse, sometimes mockall will generate code that fails to compile, because the Where clauses reference generic parameters that aren't there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, generic structs implementing Future. The method must not be treated as a generic method, since it has a non-static argument.
Issue #223