Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Instances::default() empty #250

Merged
merged 1 commit into from
May 22, 2022
Merged

Conversation

emilk
Copy link
Contributor

@emilk emilk commented May 21, 2022

It is very surprising that Instances::default() isn't empty.
It is very useful to start with the default and add things to it piece-meal.

It is very surprising that Instances::default() isn't empty.
It is very useful to start with the default and add things to it piece-meal.
@emilk emilk mentioned this pull request May 21, 2022
@asny
Copy link
Owner

asny commented May 21, 2022

Didn't think that you wanted to create Instances with no instances, but it makes sense if you want to create an empty InstancedMesh and later update the instances. If that makes sense 😂 Anyway, this will break a few of the examples so need to update them before I merge.

@asny asny merged commit 1203753 into asny:master May 22, 2022
@emilk emilk deleted the empty-default-instances branch May 22, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants