Handle OPTIONS cacheable #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this would make sure that Preflight requests and OPTIONS requests are handled same as before, only the Vary header is added for the Methods, so preflight / non-preflight will be cached separately. Origin check is removed so it it doesn't create cache entries per origin. |
|
This looks perfect to me. |
src/CorsService.php
Outdated
| @@ -166,7 +164,7 @@ private function configureAllowedMethods(Response $response, Request $request) | |||
| if ($this->options['allowedMethods'] === true) { | |||
| if ($this->options['supportsCredentials']) { | |||
| $allowMethods = strtoupper($request->headers->get('Access-Control-Request-Method')); | |||
| $this->varyHeader($response, 'Access-Control-Request-Method'); | |||
| // Vary is always done | |||
There was a problem hiding this comment.
maybe more specific?
// Vary by Access-Control-Request-Method is added to every preflight request.
There was a problem hiding this comment.
Tweaked it a bit by just adding it and detect duplicates, in case the CorsService is used stand-alone or with a custom middleware.
|
FYI, I've tweaked it a bit in 03157d5 |
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #70 (comment) by @davidbarratt