forked from crosswalk-project/v8-crosswalk
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[regexp] Fix two more possible shape changes on fast path
This CL fixes two more cases in which a regexp could unintentionally transition to slow mode while on the fast path, leading to possible OOB accesses of lastIndex. In both cases, the fix is to re-check the shape and possibly bail to runtime. BUG=chromium:708247,v8:6210 Review-Url: https://codereview.chromium.org/2803603005 Cr-Commit-Position: refs/heads/master@{#44451}
- Loading branch information
Showing
2 changed files
with
64 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// Copyright 2017 the V8 project authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
// Flags: --predictable | ||
|
||
const str = '2016-01-02'; | ||
|
||
function testToUint32InSplit() { | ||
var re; | ||
function toDictMode() { | ||
re.x = 42; | ||
delete re.x; | ||
return "def"; | ||
} | ||
|
||
re = /./g; // Needs to be global to trigger lastIndex accesses. | ||
return re[Symbol.replace]("abc", { valueOf: toDictMode }); | ||
} | ||
|
||
function testToStringInReplace() { | ||
var re; | ||
function toDictMode() { | ||
re.x = 42; | ||
delete re.x; | ||
return 42; | ||
} | ||
|
||
re = /./g; // Needs to be global to trigger lastIndex accesses. | ||
return re[Symbol.split]("abc", { valueOf: toDictMode }); | ||
} | ||
|
||
testToUint32InSplit(); | ||
testToStringInReplace(); |