React server #27
React server #27
Conversation
… the app file to allow for commit #26
FarahZaqout
requested review from
amusameh,
ashatat,
ishak52 and
RamyAlshurafa
|
@FarahZaqout
you can read his comment is these issues |
client/public/index.html
Outdated
| work correctly both with client-side routing and a non-root public URL. | ||
| Learn how to configure a non-root public URL by running `npm run build`. | ||
| --> | ||
| <title>React App</title> |
There was a problem hiding this comment.
I Think we should change this title into a real one
client/public/index.html
Outdated
| <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> | ||
| <meta name="theme-color" content="#000000"> | ||
| <!-- |
There was a problem hiding this comment.
No needs for these commented lines.
what do you think?
| import React from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
| import App from './App'; | ||
| import * as serviceWorker from './serviceWorker'; |
There was a problem hiding this comment.
Do you want to make it off-line app?
if not so I think no needs for serviceWorker
There was a problem hiding this comment.
I think it's good to try and make it a progressive app.
Yeah, a lot of people are pushing towards this. However, for some reason airbnb refuses to buckle. |
|
Maybe I should just disable the rule in eslint? |
FarahZaqout
dismissed stale reviews from amusameh, ashatat, and ishak52
via
c3866be
FarahZaqout
requested review from
amusameh,
ashatat,
ishak52 and
RamyAlshurafa
create react server with create-react-app
#26