Fixes #1275. Fix unresolved dependency grolifant and okhttp-digest #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
The build does not work anymore since a few weeks because a couple of dependencies cannot be resolved anymore, namely grolifant and okhttp-digest.
This PR tries to fix the build again.
How does it achieve that?
Move the dependency on the plugin to an old style plugin dependency, and specify an explicit dependency on grolifant.
Are there any alternative ways to implement this?
Probably.
For example getting rid of Gradle altogether, or installing gems with some other mechanism, like Maven.
Are there any implications of this pull request? Anything a user must know?
Issue
Fixes #1275