Fix remaining compiler warnings #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need a way to determine if intptr_t/uintptr_t are available: Config.pm does not appear to mention these types; since these types are not mandatory for inttypes.h, they may be unavailable even if Config.pm says inttypes.h is available. May want Perl/Tk to define HAVE_INTTYPES_H in tkConfig.h
chrstphrchvz
referenced
this pull request
Nov 30, 2020
Correctly handle packaged pTk.exc (and possible pTk.inc) files whose line endings may differ from `$/`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments for 7f03179: I figured out how the remaining compiler warnings could be addressed in upstream Tktable (using approaches from recent Tcl/Tk and extensions), but not Tk::TableMatrix. I believe I need a way to determine if
intptr_tanduintptr_tare available, which Config.pm does not appear to provide; since these types are not mandatory for inttypes.h, they may be unavailable even if$Config{'i_inttypes'}is defined. It may also be desirable for Perl/Tk to defineHAVE_INTTYPES_Hin tkConfig.h when appropriate.