Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to set alternate language(s) #318

Merged
merged 4 commits into from
May 20, 2024

Conversation

DevDavido
Copy link
Contributor

@DevDavido DevDavido commented Feb 10, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Tests pass? ✔️

Hi, thank you for the useful package!

It almost fits my requirements fully, except one case:
For a multi-language site all alternate language links are generated automatically as they all have the same structured URL. However, if an localised version of the site does not exist or if the originally requested page does not exist either, I want to be able to remove the alternate language meta links. So that crawlers not unnecessary crawl those 404 page(s) and reducing the crawling budget on top. For the other properties in this package that's possible by setting the value to false, however this does not work for the alternate languages (append only currently, no filtering of falsy values during tag generation). Therefore, I added an possibility to set alternate language(s) and filter out falsy values thereof. Documentation and tests are provided too for this added functionality.

Looking forward to your feedback or even better, a merge and release with the feature. Thanks!

@J-Brk
Copy link
Collaborator

J-Brk commented Feb 22, 2024

Thank you for your contribution!

@J-Brk J-Brk self-requested a review February 22, 2024 16:19
@J-Brk J-Brk added the feature label Feb 22, 2024
@DevDavido
Copy link
Contributor Author

You're welcome! I'm glad to hear you appreciate the contribution. Let me know if there's anything else I can do to help move this forward.

@DevDavido
Copy link
Contributor Author

Hi @J-Brk @vinicius73, is there anything I could do to help get this PR merged (and released)?

@vinicius73 vinicius73 merged commit 44920c7 into artesaos:master May 20, 2024
6 checks passed
@DevDavido DevDavido deleted the feature/set-alternate-language branch May 20, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants