Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent self-closing tag syntax #287

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Prevent self-closing tag syntax #287

merged 1 commit into from
Sep 28, 2022

Conversation

stefket
Copy link
Contributor

@stefket stefket commented Sep 28, 2022

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Tests pass? ✔️
Fixed issues -

The w3c validator recently produces warnings, if you use the self-closing tag syntax.

@J-Brk
Copy link
Collaborator

J-Brk commented Sep 28, 2022

Thank you for your contribution. Are you sure the w3c change is recent? Because as I remember this recommendation / problem has been around for a long time.

I think it would be good to match the w3c standard. Unfortunately, most developers are using open and self-closing without any consistency, just take this GitHub page as example where both are used.

@stefket
Copy link
Contributor Author

stefket commented Sep 28, 2022

I think it's a recent change, but I'm not sure.

The w3c validator links to the following page: https://google.github.io/styleguide/htmlcssguide.html#Document_Type with the following statement:

Although fine with HTML, do not close void elements, i.e. write <br>, not <br />.

@stefket
Copy link
Contributor Author

stefket commented Sep 28, 2022

I've found a post on stackoverflow https://stackoverflow.com/a/73870374/2499739 where someone writes, that this is a pretty new change.

@vinicius73
Copy link
Member

To make sure it will not cause problems, what do you think about release it as a major version @J-Brk ?

@J-Brk
Copy link
Collaborator

J-Brk commented Sep 28, 2022

@vinicius73 Yeah, good idea, let's make this a new major version!

@vinicius73 vinicius73 merged commit 0c5e723 into artesaos:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants