Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to generate few JsonLd Group #197

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Conversation

yepzy
Copy link

@yepzy yepzy commented Jan 8, 2020

On a project I have page that require few JsonLd group and with the current implement, only one JsonLd can be filled.

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Tests pass? ✔️
Fixed issues -

@Okipa
Copy link

Okipa commented Jan 10, 2020

+1.

Would be great indeed to have the ability to generate multiple JsonLD meta, it is sometimes required : https://stackoverflow.com/questions/30723531/best-json-ld-practices-using-multiple-script-elements.

There may be a better way to implement that by modifying the JsonLD architecture ?

Would you have another idea on how implementing this ? We may update this PR if you point us the way you would accept such a feature.

@vinicius73
Copy link
Member

@yepzy thanks a lot for this PR
Is a big feature.

@emtudo can you help me to review this PR?

@emtudo emtudo merged commit e223bf8 into artesaos:master Jun 19, 2020
@emtudo
Copy link
Member

emtudo commented Jun 19, 2020

It's ok!

thanks!

@Okipa
Copy link

Okipa commented Jun 20, 2020

Thanks ! Congratz @yepzy ;)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants