Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Django in MCP client scripts ref. #8879 #267

Merged
merged 1 commit into from
Sep 16, 2015

Conversation

hakamine
Copy link
Member

Standalone scripts require to initialize Django to avoid
an AppRegistryNotReady exception

So far identified 3 scripts, others may also need to be fixed.

@Hwesta
Copy link
Contributor

Hwesta commented Sep 9, 2015

Thanks for catching these! I've been putting the Django setup stuff after the system imports (eg import os but before any AM specific imports (like from archivematicaCommon or models) in case those files also need Django to be set up before they're imported. If it works like this, though, don't worry about changing it.

@jhsimpson
Copy link
Member

I tested this with the upload_archivessspace.py and it works,

👍

Standalone scripts require to initialize Django to avoid
an AppRegistryNotReady exception

So far identified 3 scripts, others may also need to be fixed.
@qubot qubot force-pushed the dev/issue-8879-mcp-client-scripts-fix-django-1.7 branch from 6b54925 to 1ba89ce Compare September 16, 2015 17:10
@qubot qubot merged commit 1ba89ce into qa/1.x Sep 16, 2015
@qubot qubot deleted the dev/issue-8879-mcp-client-scripts-fix-django-1.7 branch September 16, 2015 17:11
@Hwesta
Copy link
Contributor

Hwesta commented Sep 21, 2015

Cherry-picked to qa/1.5.x as bf50761

@Hwesta Hwesta added this to the 1.5.0 milestone Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants