Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend test coverage of normalize script #1972

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Extend test coverage of normalize script #1972

merged 3 commits into from
Aug 12, 2024

Conversation

replaceafill
Copy link
Member

This also adds type hints to the normalize script and its tests.

@replaceafill replaceafill added the AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests label Aug 12, 2024
@replaceafill replaceafill removed the AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests label Aug 12, 2024
Dhwaniartefact
Dhwaniartefact approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@replaceafill replaceafill merged commit 725b170 into qa/1.x Aug 12, 2024
45 checks passed
@replaceafill replaceafill deleted the dev/extend-test-coverage-normalize branch August 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhwaniartefact Dhwaniartefact Dhwaniartefact approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@replaceafill @Dhwaniartefact