Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined vars build warnings in Dockerfile #1971

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

replaceafill
Copy link
Member

Similar to artefactual/archivematica-storage-service#734 this fixes the following build warnings:

Click to expand warnings
$ docker build --check .
[+] Building 0.7s (4/4) FINISHED                                                                                          docker:default
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 9.00kB                                                                                              0.0s
 => [internal] load metadata for docker.io/library/node:20                                                                          0.6s
 => [internal] load metadata for docker.io/library/ubuntu:22.04                                                                     0.7s
 => [internal] load .dockerignore                                                                                                   0.0s
 => => transferring context: 2B                                                                                                     0.0s

WARNING: UndefinedVar - https://docs.docker.com/go/dockerfile/rule/undefined-var/
Usage of undefined variable '$USER_ID'
Dockerfile:139
--------------------
 137 |          && rm -rf /var/lib/apt/lists/* /var/cache/apt/*
 138 |     
 139 | >>> COPY --chown=${USER_ID}:${GROUP_ID} --from=browsers-builder --link ${SELENIUM_DIR} ${SELENIUM_DIR}
 140 |     COPY --chown=${USER_ID}:${GROUP_ID} --from=archivematica-dashboard-frontend-builder --link /src/src/dashboard/frontend/node_modules /src/src/dashboard/frontend/node_modules
 141 |     COPY --link src/dashboard/frontend /src/src/dashboard/frontend
--------------------

WARNING: UndefinedVar - https://docs.docker.com/go/dockerfile/rule/undefined-var/
Usage of undefined variable '$GROUP_ID'
Dockerfile:139
--------------------
 137 |          && rm -rf /var/lib/apt/lists/* /var/cache/apt/*
 138 |     
 139 | >>> COPY --chown=${USER_ID}:${GROUP_ID} --from=browsers-builder --link ${SELENIUM_DIR} ${SELENIUM_DIR}
 140 |     COPY --chown=${USER_ID}:${GROUP_ID} --from=archivematica-dashboard-frontend-builder --link /src/src/dashboard/frontend/node_modules /src/src/dashboard/frontend/node_modules
 141 |     COPY --link src/dashboard/frontend /src/src/dashboard/frontend
--------------------

WARNING: UndefinedVar - https://docs.docker.com/go/dockerfile/rule/undefined-var/
Usage of undefined variable '$USER_ID'
Dockerfile:140
--------------------
 138 |     
 139 |     COPY --chown=${USER_ID}:${GROUP_ID} --from=browsers-builder --link ${SELENIUM_DIR} ${SELENIUM_DIR}
 140 | >>> COPY --chown=${USER_ID}:${GROUP_ID} --from=archivematica-dashboard-frontend-builder --link /src/src/dashboard/frontend/node_modules /src/src/dashboard/frontend/node_modules
 141 |     COPY --link src/dashboard/frontend /src/src/dashboard/frontend
 142 |     
--------------------

WARNING: UndefinedVar - https://docs.docker.com/go/dockerfile/rule/undefined-var/
Usage of undefined variable '$GROUP_ID'
Dockerfile:140
--------------------
 138 |     
 139 |     COPY --chown=${USER_ID}:${GROUP_ID} --from=browsers-builder --link ${SELENIUM_DIR} ${SELENIUM_DIR}
 140 | >>> COPY --chown=${USER_ID}:${GROUP_ID} --from=archivematica-dashboard-frontend-builder --link /src/src/dashboard/frontend/node_modules /src/src/dashboard/frontend/node_modules
 141 |     COPY --link src/dashboard/frontend /src/src/dashboard/frontend
 142 |     
--------------------

@replaceafill replaceafill requested a review from a team August 11, 2024 18:00
@replaceafill replaceafill added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Aug 11, 2024
Copy link
Member

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@replaceafill replaceafill merged commit 484c55a into qa/1.x Aug 12, 2024
45 checks passed
@replaceafill replaceafill deleted the dev/fix-dockerfile-build-check branch August 12, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants