Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only active rules for transcription #1956

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

Dhwaniartefact
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact commented Jul 11, 2024

Active FPRule for Tessaract is now correctly filtered by this change.

connected to archivematica/Issues#1630

@Dhwaniartefact Dhwaniartefact marked this pull request as ready for review July 11, 2024 19:45
@Dhwaniartefact Dhwaniartefact changed the title Dev/issue tesseract ocr command disabled Tesseract OCR command runs even if disabled Jul 11, 2024
If any command is disabled in Preservation Planning,
the rules should be disabled and the tool shouldn't run.
@Dhwaniartefact Dhwaniartefact force-pushed the dev/issue-tesseract-ocr-command-disabled branch from 8f76a5c to fadc6c8 Compare July 11, 2024 20:52
Copy link
Member

@replaceafill replaceafill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work fixing this @Dhwaniartefact!

@Dhwaniartefact Dhwaniartefact changed the title Tesseract OCR command runs even if disabled Use only active rules for transcription Jul 12, 2024
@Dhwaniartefact Dhwaniartefact merged commit bbc4bb2 into qa/1.x Jul 12, 2024
26 checks passed
@Dhwaniartefact Dhwaniartefact deleted the dev/issue-tesseract-ocr-command-disabled branch July 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants