Add test for transcribe_file #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhwaniartefact
force-pushed
the
dev/issue-extend-test-coverage-for-transcribe-file
branch
from
96c55f7
to
4672243
Compare
Dhwaniartefact
force-pushed
the
dev/issue-extend-test-coverage-for-transcribe-file
branch
from
4672243
to
221747e
Compare
|
@Dhwaniartefact is this ready for review? It's still marked as |
replaceafill
requested changes
Jul 10, 2024
Comment on lines
144
to
150
| assert models.Event.objects.filter(event_type="transcription").count() == 1 | ||
| assert models.File.objects.count() == 2 | ||
| assert models.File.objects.filter(filegrpuse="original").count() == 1 | ||
| assert models.File.objects.filter(filegrpuse="text/ocr").count() == 1 | ||
| assert ( | ||
| models.Derivation.objects.filter(event__event_type="transcription").count() == 1 | ||
| ) |
There was a problem hiding this comment.
Could these filter calls include more criteria attributes? Fox example the transcription event has other meaningful attributes like detail, outcome or note that you can assert. The derivation could also have the source and derived files as criteria.
replaceafill
approved these changes
Jul 10, 2024
Dhwaniartefact
deleted the
dev/issue-extend-test-coverage-for-transcribe-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend test coverage of "transcribe_file.py"