-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for transcribe_file #1954
Add test for transcribe_file #1954
Conversation
96c55f7
to
4672243
Compare
4672243
to
221747e
Compare
@Dhwaniartefact is this ready for review? It's still marked as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress @Dhwaniartefact.
assert models.Event.objects.filter(event_type="transcription").count() == 1 | ||
assert models.File.objects.count() == 2 | ||
assert models.File.objects.filter(filegrpuse="original").count() == 1 | ||
assert models.File.objects.filter(filegrpuse="text/ocr").count() == 1 | ||
assert ( | ||
models.Derivation.objects.filter(event__event_type="transcription").count() == 1 | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these filter
calls include more criteria attributes? Fox example the transcription event has other meaningful attributes like detail, outcome or note that you can assert. The derivation could also have the source and derived files as criteria.
Extend test coverage of "transcribe_file.py"