Check error in OpenSQLConnection (kubeflow#588)

* Check error in openSQLconn * Add logic in v1alpha1 * Change to Errorf
arrikto · May 28, 2019 · 4f678e2 · 4f678e2
1 parent c2b6f9e
commit 4f678e2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pkg/db/v1alpha1/interface.go b/pkg/db/v1alpha1/interface.go
@@ -111,6 +111,9 @@ func openSQLConn(driverName string, dataSourceName string, interval time.Duratio
 				if err = db.Ping(); err == nil {
 					return db, nil
 				}
+				klog.Errorf("Ping to Katib db failed: %v", err)
+			} else {
+				klog.Errorf("Open sql connection failed: %v", err)
 			}
 		case <-timeoutC:
 			return nil, fmt.Errorf("Timeout waiting for DB conn successfully opened.")

diff --git a/pkg/db/v1alpha2/interface.go b/pkg/db/v1alpha2/interface.go
@@ -95,6 +95,9 @@ func openSQLConn(driverName string, dataSourceName string, interval time.Duratio
 				if err = db.Ping(); err == nil {
 					return db, nil
 				}
+				klog.Errorf("Ping to Katib db failed: %v", err)
+			} else {
+				klog.Errorf("Open sql connection failed: %v", err)
 			}
 		case <-timeoutC:
 			return nil, fmt.Errorf("Timeout waiting for DB conn successfully opened.")