Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oneflow backend #180

Merged
merged 5 commits into from
Mar 27, 2022
Merged

Conversation

rentainhe
Copy link
Contributor

@rentainhe rentainhe commented Mar 21, 2022

Introduction

Hello! I try to add OneFlow backend into einops, here's my PR~

TODO

Question

  • How should I do some tests based on the new Backend? I've already do some simple tests based on the basic usage of einops and all of them worked, but how should I do some official tests on more cases~

@arogozhnikov arogozhnikov mentioned this pull request Mar 27, 2022
@arogozhnikov arogozhnikov merged commit ef93670 into arogozhnikov:master Mar 27, 2022
@arogozhnikov
Copy link
Owner

Well written, thanks.

Tests are expected to work on both linux and mac.
Oneflow seems to provide wheels only for linux, so I've made some adjustments to skip it in non-linux tests.

@rentainhe
Copy link
Contributor Author

Well written, thanks.

Tests are expected to work on both linux and mac. Oneflow seems to provide wheels only for linux, so I've made some adjustments to skip it in non-linux tests.

Thanks a lot ! ! ! I really appreciate your work, thanks for adding OneFlow as backend~

@rentainhe rentainhe deleted the add_oneflow_backend branch March 27, 2022 10:00
@rentainhe
Copy link
Contributor Author

rentainhe commented Mar 27, 2022

sorry, I forgot to update the README, could you help me to add oneflow in README? Thanks a lot~ @arogozhnikov

@arogozhnikov
Copy link
Owner

yup, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants