[WIP] Enable ellipsis in patterns for parse_shape. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriy-serdyuk
changed the title
|
@arogozhnikov could you take a look and enable the automatic tests for this PR? |
dmitriy-serdyuk
force-pushed
the
add-parse-shape-ellipsis
branch
4 times, most recently
from
d8f6e81
to
25849b2
Compare
dmitriy-serdyuk
changed the title
Now parse_shape can accept ellipsis the same as other operations. For example, `parse_shape(np.zeros((10, 20, 30, 40)), 'a ... b')` returns `dict(a=10, b=40)`
dmitriy-serdyuk
force-pushed
the
add-parse-shape-ellipsis
branch
from
25849b2
to
572e26c
Compare
|
looks good, thanks for commenting tricky places with mxnet and keras |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now parse_shape can accept ellipsis the same as other operations.
For example,
parse_shape(np.zeros((10, 20, 30, 40)), 'a ... b')returns
dict(a=10, b=40)TODO:
Fixes #161