Compiling problem on FreeBSD

[sakai366]

A compiling problem occurs due to missing #include <netinet/in.h> in src/random.cpp.
Will you fix the source?

diff --git a/src/random.cpp b/src/random.cpp
index c87170b..872d418 100644
--- a/src/random.cpp
+++ b/src/random.cpp
@@ -81,6 +81,7 @@ static uint64_t hash_machine_identifier () {
 #ifndef __WIN32
 
 extern "C" {
+#include <netinet/in.h>
 #include <ifaddrs.h>
 #include <netdb.h>
 #include <stdio.h>

[m-fleury]

What is the compilation issue? I assume that some type is not defined on FreeBSD, but which one?

[sakai366]

The current code in master branch causes the following compile error on FreeBSD:

g++ -Wall -Wextra -O3 -DNDEBUG -I../build -I/home/fs6/sakai/proj/naps/cadical/src -c /home/fs6/sakai/proj/naps/cadical/src/random.cpp -o src/random.o
/home/fs6/sakai/proj/naps/cadical/src/random.cpp: In function 'uint64_t CaDiCaL::hash_network_addresses()':
/home/fs6/sakai/proj/naps/cadical/src/random.cpp:112:48: error: invalid application of 'sizeof' to incomplete type 'CaDiCaL::hash_network_addresses()::sockaddr_in'
  112 |         const int size = (family == AF_INET) ? sizeof (struct sockaddr_in)
      |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/fs6/sakai/proj/naps/cadical/src/random.cpp:113:48: error: invalid application of 'sizeof' to incomplete type 'CaDiCaL::hash_network_addresses()::sockaddr_in6'
  113 |                                              : sizeof (struct sockaddr_in6);
      |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

[m-fleury]

Seems to be a freebsd thing: on linux and openbsd, netdb.h actually includes netinet/in.h but not on freebsd https://github.com/OpenOrbis/freebsd-headers/blob/master/include/lwres/netdb.h.

The next release should include the missing import.