AR-1142 - refactor install_docker to be based on the family #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Motivation
This PR was initially motivated by the issue https://armbian.atlassian.net/browse/AR-1142
Upon checking the code, I've noticed it was not exactly as mentioned in the issue
config/debian-software
Line 649 in c9a9b49
Still, I believe there was yet room for improvement, thus this PR 😄
After reviewing the
install_docker
function, I've noticed that it is still tied to specific Debian/Ubuntu versions. In my opinion this is not desired, as will require further maintenance in the future, in order to support newer linux versions.Changes
Tests
Installation of Docker, using the tool on a freshly installed:
Note: In order to speed-up the test process, I've done both tests using WSL2 on Windows 10 (AMD64). I know it's not ideal, but I believe the code, as is, should be independent from the HW architecture.
If you have any question, feedback or suggestion, please do not hesitate to say so :)
Thank you