Skip to content

Commit

Permalink
Closes #1 Adds a spec to verify that joining emoji works correctly
Browse files Browse the repository at this point in the history
  • Loading branch information
armahillo committed Oct 6, 2020
1 parent 7e6434c commit 30682b2
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

N.B. until it hits 1.0 do not make any expectations about API consistency! (SemVer says it's OK so nyah!)

## [0.4.0] - 2020-10-05

- Adds a spec to verify that join-emojis work correctly; apparently it already works!

## [0.3.0] - 2020-10-05

- Adds monkey-patch to allow String to call `:emoji_sub` directly
Expand Down Expand Up @@ -46,6 +50,7 @@ emoji HTML entities (hex-unicode) for slack shortcut format (:this_kind:)
- data/emoji.yml file,
- Specs covering basic funcitonality

[0.4.0]: https://github.com/armahillo/emoji_sub/compare/v0.3.0...v0.4.0
[0.3.0]: https://github.com/armahillo/emoji_sub/compare/v0.2.2...v0.3.0
[0.2.2]: https://github.com/armahillo/emoji_sub/compare/v0.2.1...v0.2.2
[0.2.1]: https://github.com/armahillo/emoji_sub/compare/v0.2.0...v0.2.1
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ GIT
PATH
remote: .
specs:
emoji_sub (0.2.2)
emoji_sub (0.3.0)

GEM
remote: https://rubygems.org/
Expand Down
Binary file added emoji_sub-0.4.0.gem
Binary file not shown.
2 changes: 1 addition & 1 deletion lib/emoji_sub/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module EmojiSub
VERSION = "0.3.0"
VERSION = "0.4.0"
end
8 changes: 8 additions & 0 deletions spec/emoji_sub_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,13 @@
end
end
end

context "when a shortcode returns multiple emoji" do
let(:text) { ':rainbow-flag: Proud Boys! :rainbow-flag:' }

it "combines them together" do
expect(subject).to eq("&#x1F3F3&#xFE0F&#x200D&#x1F308 Proud Boys! &#x1F3F3&#xFE0F&#x200D&#x1F308")
end
end
end
end

0 comments on commit 30682b2

Please sign in to comment.