This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weikengchen
changed the title
Prepared G2 consistency test (merged in the next release)
Prepared G2 consistency test (to be merged in the next release)
Aug 11, 2021
Pratyush
approved these changes
Oct 30, 2022
weikengchen
changed the title
Prepared G2 consistency test (to be merged in the next release)
Prepared G2 consistency test
Oct 31, 2022
Memory appears to be insufficient---now trying to use macos-latest instead. |
Pratyush
approved these changes
Oct 31, 2022
Finally. |
Thanks for this @weikengchen !! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a consistency test for the g2 prepared element for BLS12-377.
There is space of improvement for this test:
G2PreparedGadget
at this moment only implementsToBytesGadget
but notEqGadget
, and therefore the code here converts them to bytes first and performs the checks, which is suboptimal.Especially, this conversion seems to be extremely expensive, so that it cannot be used for MNT4/6-753. Therefore, the new test is not used on those curves.
This PR is related to arkworks-rs/r1cs-std#77
Since the bug for BLS12-377 will only be fixed once this repo is based on the newer release, it is expected that the test will fail until then, and this PR should only be merged in the next release.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Files changed
in the Github PR explorerN/A:
Pending
section inCHANGELOG.md