Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Prepared G2 consistency test #70

Merged
merged 24 commits into from
Nov 1, 2022
Merged

Prepared G2 consistency test #70

merged 24 commits into from
Nov 1, 2022

Conversation

weikengchen
Copy link
Member

Description

This PR adds a consistency test for the g2 prepared element for BLS12-377.

There is space of improvement for this test: G2PreparedGadget at this moment only implements ToBytesGadget but not EqGadget, and therefore the code here converts them to bytes first and performs the checks, which is suboptimal.

Especially, this conversion seems to be extremely expensive, so that it cannot be used for MNT4/6-753. Therefore, the new test is not used on those curves.

This PR is related to arkworks-rs/r1cs-std#77

Since the bug for BLS12-377 will only be fixed once this repo is based on the newer release, it is expected that the test will fail until then, and this PR should only be merged in the next release.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Re-reviewed Files changed in the Github PR explorer

N/A:

  • Added a relevant changelog entry to the Pending section in CHANGELOG.md

@weikengchen weikengchen changed the title Prepared G2 consistency test (merged in the next release) Prepared G2 consistency test (to be merged in the next release) Aug 11, 2021
@weikengchen weikengchen changed the title Prepared G2 consistency test (to be merged in the next release) Prepared G2 consistency test Oct 31, 2022
@weikengchen
Copy link
Member Author

Memory appears to be insufficient---now trying to use macos-latest instead.

@weikengchen
Copy link
Member Author

Finally.

@weikengchen weikengchen merged commit 9983165 into master Nov 1, 2022
@weikengchen weikengchen deleted the add-g2-prepared-test branch November 1, 2022 00:12
@Pratyush
Copy link
Member

Pratyush commented Nov 1, 2022

Thanks for this @weikengchen !!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants