Add support for hex, octal, and binary input in BigInt and MontFp macros
#635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
requested review from
mmagician and
weikengchen
and removed request for
a team
Pratyush
added
T-bug
Pratyush
changed the title
BigInt and MontFp…BigInt and MontFp macros
weikengchen
approved these changes
Apr 1, 2023
…lgebra into hex-octal-binary-in-bigint
mmagician
approved these changes
Apr 2, 2023
6 tasks
aleasims
pushed a commit
to NilFoundation/arkworks-algebra
that referenced
this pull request
Oct 18, 2023
… macros (arkworks-rs#635) * Add support for hex, octal, and binary input in `BigInt` and `MontFp` macros * Fix re-exports * Format
aleasims
added a commit
to NilFoundation/arkworks-algebra
that referenced
this pull request
Oct 18, 2023
…`MontFp` macros (arkworks-rs#635)" This reverts commit 0239689.
mmagician
pushed a commit
to mmagician/algebra
that referenced
this pull request
Nov 3, 2023
… macros (arkworks-rs#635) * Add support for hex, octal, and binary input in `BigInt` and `MontFp` macros * Fix re-exports * Format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for binary, octal, and hexadecimal inputs in the
BigIntandMontFpmacros. Also fixes some nightly CI failures.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer