This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to ng6 Angular library.
If interested, I'd need to go through this more carefully to ensure this aligns to previous expectations.
My goal here was to convert to a "proper" Angular library for some Ivy compiler tests I'd like to run.
If not interested feel free to decline; I won't put the extra effort to re-align the doc/lint/etc.
Edit:
A little more context. When trying to test the Ivy compiler
ng-inline-svg
was failing to build despite running through the compatibility compiler. It appeared this was due to the fact that this library was not Angular Package Format. I've now confirmed in:https://github.com/rcketscientist/ng-inline-svg/tree/ivyCompiler
that
ng-inline-svg
will indeed build with the Ivy compiler once converted to APF. Ivy is targetted for ng9, so this is not necessarily a rush, but will be necessary eventually.