Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Port to angular library #104

Closed

Conversation

rcketscientist
Copy link

@rcketscientist rcketscientist commented Mar 18, 2019

Migrate to ng6 Angular library.

If interested, I'd need to go through this more carefully to ensure this aligns to previous expectations.

My goal here was to convert to a "proper" Angular library for some Ivy compiler tests I'd like to run.

If not interested feel free to decline; I won't put the extra effort to re-align the doc/lint/etc.

Edit:

A little more context. When trying to test the Ivy compiler ng-inline-svg was failing to build despite running through the compatibility compiler. It appeared this was due to the fact that this library was not Angular Package Format. I've now confirmed in:
https://github.com/rcketscientist/ng-inline-svg/tree/ivyCompiler
that ng-inline-svg will indeed build with the Ivy compiler once converted to APF. Ivy is targetted for ng9, so this is not necessarily a rush, but will be necessary eventually.

@arkon
Copy link
Owner

arkon commented Apr 7, 2019

I'll look into this later, but I generally believe the boilerplate template that the CLI gives contains too much unnecessary stuff for my needs.

@MatejBivr
Copy link

any updates on this? thanks!

@rcketscientist
Copy link
Author

I forked it and published it under @rcketscientist

@arkon
Copy link
Owner

arkon commented Jan 16, 2020

I think this library should now work fine with Ivy (in Angular 9+).

@arkon arkon closed this Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants