-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(plugins): Remove jsonschema dependency #4348
Merged
carlbuchmann
merged 16 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/plugins/reimplement-schema-validation-to-remove-jsonschema-dependency
Aug 16, 2024
Merged
Refactor(plugins): Remove jsonschema dependency #4348
carlbuchmann
merged 16 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/plugins/reimplement-schema-validation-to-remove-jsonschema-dependency
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4348
# Activate the virtual environment
source test-avd-pr-4348/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/plugins/reimplement-schema-validation-to-remove-jsonschema-dependency#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/plugins/reimplement-schema-validation-to-remove-jsonschema-dependency --force
# Optional: Install AVD examples
cd test-avd-pr-4348
ansible-playbook arista.avd.install_examples |
60a0597
to
0fd1af3
Compare
293146e
to
5a452ba
Compare
for more information, see https://pre-commit.ci
…ion-to-remove-jsonschema-dependency
|
carlbuchmann
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Refactor(plugins)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
type: documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove jsonschema dependency
Component(s) name
Schema validation
Proposed changes
extend_schema
method.