-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_designs): Move schema for ipv4_prefix_list_catalog to pyavd for proper enforcement #4322
Merged
ClausHolbechArista
merged 2 commits into
aristanetworks:devel
from
ClausHolbechArista:fix/eos_designs/schema-for-ipv4_prefix_list_catalog
Aug 6, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4322
# Activate the virtual environment
source test-avd-pr-4322/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/schema-for-ipv4_prefix_list_catalog#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/schema-for-ipv4_prefix_list_catalog --force
# Optional: Install AVD examples
cd test-avd-pr-4322
ansible-playbook arista.avd.install_examples |
Vibhu-gslab
approved these changes
Aug 6, 2024
MaheshGSLAB
approved these changes
Aug 6, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
58b8690
to
e0ae88a
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…or proper enforcement (aristanetworks#4322)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Fix(eos_designs)
role: eos_designs
issue related to eos_designs role
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move schema for ipv4_prefix_list_catalog to pyavd for proper enforcement
Component(s) name
arista.avd.eos_designs
Proposed changes
During the move to PyAVD in AVD 4.9 the schema for
ipv4_prefix_list_catalog
was missed - most likely because of a bad rebase.This change moves the schema. There should be no behavioral changes.
How to test
Already tested with molecule.
Checklist
User Checklist
Repository Checklist