Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Move schema for ipv4_prefix_list_catalog to pyavd for proper enforcement #4322

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Move schema for ipv4_prefix_list_catalog to pyavd for proper enforcement

Component(s) name

arista.avd.eos_designs

Proposed changes

During the move to PyAVD in AVD 4.9 the schema for ipv4_prefix_list_catalog was missed - most likely because of a bad rebase.
This change moves the schema. There should be no behavioral changes.

How to test

Already tested with molecule.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners August 5, 2024 14:13
Copy link

github-actions bot commented Aug 5, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4322
# Activate the virtual environment
source test-avd-pr-4322/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/schema-for-ipv4_prefix_list_catalog#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/schema-for-ipv4_prefix_list_catalog --force
# Optional: Install AVD examples
cd test-avd-pr-4322
ansible-playbook arista.avd.install_examples

Copy link

github-actions bot commented Aug 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Aug 6, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the fix/eos_designs/schema-for-ipv4_prefix_list_catalog branch from 58b8690 to e0ae88a Compare August 6, 2024 11:00
@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

sonarcloud bot commented Aug 6, 2024

@ClausHolbechArista ClausHolbechArista merged commit 0b93cd4 into aristanetworks:devel Aug 6, 2024
40 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
@ClausHolbechArista ClausHolbechArista deleted the fix/eos_designs/schema-for-ipv4_prefix_list_catalog branch August 20, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants