-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(plugins): Move jinja filter code for arista.avd.add_md_toc to PyAVD #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4104
# Activate the virtual environment
source test-avd-pr-4104/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@add_md_toc_filter#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,add_md_toc_filter --force
# Optional: Install AVD examples
cd test-avd-pr-4104
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: code quality
CI and development toolset
type: Python filters
labels
Jun 12, 2024
ClausHolbechArista
requested changes
Jun 12, 2024
ClausHolbechArista
approved these changes
Jun 13, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Jun 13, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
Quality Gate passedIssues Measures |
Vibhu-gslab
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Refactor(plugins)
type: code quality
CI and development toolset
type: Python filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move jinja filter code for arista.avd.add_md_toc to PyAVD
Related Issue(s)
Fixes #
Component(s) name
arista.avd.add_md_toc
Proposed changes
Moving the code and unit tests for arista.avd.add_md_toc filter to PyAVD
How to test
Refactored pytest + things should break
Checklist
Repository Checklist