Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja filter code for arista.avd.add_md_toc to PyAVD #4104

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jun 12, 2024

Change Summary

Move jinja filter code for arista.avd.add_md_toc to PyAVD

Related Issue(s)

Fixes #

Component(s) name

arista.avd.add_md_toc

Proposed changes

Moving the code and unit tests for arista.avd.add_md_toc filter to PyAVD

How to test

Refactored pytest + things should break

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners June 12, 2024 08:52
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4104
# Activate the virtual environment
source test-avd-pr-4104/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@add_md_toc_filter#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,add_md_toc_filter --force
# Optional: Install AVD examples
cd test-avd-pr-4104
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista requested a review from a team June 13, 2024 05:25
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jun 13, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 13, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 13, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

ClausHolbechArista and others added 2 commits June 13, 2024 09:32
Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gmuloc gmuloc merged commit e1beca7 into aristanetworks:devel Jun 14, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(plugins) type: code quality CI and development toolset type: Python filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants