Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(cv_deploy): Add CV Pathfinder AVT hop count to metadata studio #4071

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jun 4, 2024

Change Summary

Add CV Pathfinder AVT hop count to metadata studio

Tested manually by Pragnya. Thank you!

Component(s) name

arista.avd.cv_deploy

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Jun 4, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4071
# Activate the virtual environment
source test-avd-pr-4071/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@feat/cv_deploy/add-hop-count-to-metadata-studio#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,feat/cv_deploy/add-hop-count-to-metadata-studio --force
# Optional: Install AVD examples
cd test-avd-pr-4071
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jun 4, 2024
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - have not checked the updated schema

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jun 5, 2024
@gmuloc gmuloc marked this pull request as draft June 6, 2024 09:06
@gmuloc
Copy link
Contributor

gmuloc commented Jun 6, 2024

On draft until metadata studio change is approved

@github-actions github-actions bot added the state: conflict PR with conflict label Jun 17, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed role: eos_designs issue related to eos_designs role state: conflict PR with conflict labels Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review July 23, 2024 10:40
@gmuloc
Copy link
Contributor

gmuloc commented Jul 23, 2024

This has been validated by systest that the metadata studio is filled and the required pages are updated correctly

Copy link

sonarcloud bot commented Jul 23, 2024

@gmuloc gmuloc merged commit d8c0d45 into aristanetworks:devel Jul 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(cv_deploy) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants